How is my SoulSilver Pokemon team for the Elite Four?

They're looking fine at the moment. I think you should have evolved Bayleef since you can always use Full Heal and the only real status threat from the Elite Four is Toxic (and you have two steel Pokemon who are immune to it). Pupitar's moves are alright, crunch will be super effective on the first Elite Four's Pokemon. Ice Beam would be a lot better than Blizzard for accuracy purposes and that way you can take down Lance's Dragonites easily. The highest level Pokemon you'll encounter throughout the Elite Four is Lance's lvl 50 Dragonite so just level your Pokemon a bit more and you should be fine.